fix: single-origin bench payload guard + sitemap lists only servable product URLs - #2274
Merged
Merged
Conversation
…st only servable product URLs in the sitemap Two leaks between the worker's checkout (dev) and this build (main). 1. A bench pinned to one region with no region dimension declared still shipped every region the worker computed inside the page payload (extras.regions, seriesByRegion24h, cellRanks), readable in view-source though nothing rendered it. The guard keeps the pinned region's cells only. Benches that declare region tabs are untouched. 2. The sitemap listed /products/<slug> for every provider in the blob, including providers only declared on the worker's branch; the page 404s on this build and the deploy's sitemap smoke blocks the release (2026-09-08: /products/serialized). Provider URLs are now filtered to slugs declared in this build's specs, plus registry parents. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01CpArutAtXuBb1BVNUDXoYA
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hotfix against
main. Two leaks between the worker's checkout (dev) and this build.1. Region data in the page payload
/benchmarks/keyed-rpc-robinhoodon prod declares no region dimension and pinsaggregate_filters.region: sgp, yet its RSC payload carried the full us-east series, per-region p50s andcellRanks["all|us-east"], because the blob is computed from dev's two-region spec and the whole object was passed to client components. Nothing rendered it; view-source showed it.New guard in
page.tsx: when a build pins one region and declares no region tabs,extras.regions,extras.seriesByRegion24handcellRanksare reduced to the pinned region (cells keyedall/empty are kept). Benches that declare region tabs are untouched.2. Sitemap smoke blocking prod deploys
The prod sitemap listed
/products/serialized(declared on dev only), the page 404s on main, the smoke failed, and the auto-rollback step did not roll anything back (vercel rollback --yeswithout a target only reports status; the new build stayed live while the job went red). This will recur for any provider added on dev before promotion.sitemap-builder.tsnow filters provider URLs to slugs declared in this build's specs plus registryparentslugs.Note on CI: the rollback step needs a target (capture the previous prod deployment before
vercel --prodandvercel rollback <that>), otherwise the smoke gate is a red X with no effect. Not changed here; flagged.tscandeslintclean on both files.🤖 Generated with Claude Code
https://claude.ai/code/session_01CpArutAtXuBb1BVNUDXoYA